Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C735417FF5 for ; Thu, 19 Mar 2015 02:15:59 +0000 (UTC) Received: (qmail 16088 invoked by uid 500); 19 Mar 2015 02:15:59 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 16039 invoked by uid 500); 19 Mar 2015 02:15:59 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 16028 invoked by uid 99); 19 Mar 2015 02:15:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 02:15:59 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Mar 2015 02:15:58 +0000 Received: (qmail 13900 invoked by uid 99); 19 Mar 2015 02:15:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 02:15:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4FF671D450E; Thu, 19 Mar 2015 02:15:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5343127682284891072==" MIME-Version: 1.0 Subject: Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test. From: "Brian Wickman" To: "Bill Farner" Cc: "Aurora" , "Brian Wickman" Date: Thu, 19 Mar 2015 02:15:37 -0000 Message-ID: <20150319021537.391.41101@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32221/ X-Sender: "Brian Wickman" References: <20150319012016.19861.11046@reviews.apache.org> In-Reply-To: <20150319012016.19861.11046@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5343127682284891072== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review77000 ----------------------------------------------------------- seems legit - Brian Wickman On March 19, 2015, 1:20 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32221/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 1:20 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1054 > https://issues.apache.org/jira/browse/AURORA-1054 > > > Repository: aurora > > > Description > ------- > > Remove excessively low timeout in SIGTERM swallowing test. > > > Diffs > ----- > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 > > Diff: https://reviews.apache.org/r/32221/diff/ > > > Testing > ------- > > Cannot reproduce locally, but 5 seconds is an impossibly small timeout, even if we aren't testing SIGTERM swallowing. If this fails, we will get tripped by 60s timeout instead. > > > Thanks, > > Brian Wickman > > --===============5343127682284891072==--