Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 613CD10C21 for ; Wed, 18 Mar 2015 00:11:20 +0000 (UTC) Received: (qmail 24262 invoked by uid 500); 18 Mar 2015 00:11:20 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 24215 invoked by uid 500); 18 Mar 2015 00:11:20 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 24199 invoked by uid 99); 18 Mar 2015 00:11:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 00:11:20 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Mar 2015 00:11:18 +0000 Received: (qmail 23674 invoked by uid 99); 18 Mar 2015 00:10:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 00:10:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 101791D43DC; Wed, 18 Mar 2015 00:10:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5222578445080992270==" MIME-Version: 1.0 Subject: Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy. From: "Aurora ReviewBot" To: "Zameer Manji" , "David McLaughlin" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Wed, 18 Mar 2015 00:10:55 -0000 Message-ID: <20150318001055.391.18356@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32171/ X-Sender: "Aurora ReviewBot" References: <20150317235447.392.74663@reviews.apache.org> In-Reply-To: <20150317235447.392.74663@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5222578445080992270== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32171/#review76855 ----------------------------------------------------------- Master (a419863) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS src.test.python.apache.aurora.client.cli.quota ..... SUCCESS src.test.python.apache.aurora.client.cli.sla ..... SUCCESS src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS src.test.python.apache.aurora.client.cli.task ..... SUCCESS src.test.python.apache.aurora.client.cli.update ..... SUCCESS src.test.python.apache.aurora.client.cli.version ..... SUCCESS src.test.python.apache.aurora.client.config ..... SUCCESS src.test.python.apache.aurora.client.factory ..... SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS src.test.python.apache.aurora.common.test_cluster ..... SUCCESS src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS src.test.python.apache.aurora.common.test_clusters ..... SUCCESS src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS src.test.python.apache.aurora.common.test_shellify ..... SUCCESS src.test.python.apache.aurora.common.test_transport ..... SUCCESS src.test.python.apache.aurora.config.test_base ..... SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS src.test.python.apache.aurora.config.test_loader ..... SUCCESS src.test.python.apache.aurora.config.test_thrift ..... SUCCESS src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS src.test.python.apache.aurora.executor.executor_base ..... SUCCESS src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS src.test.python.apache.aurora.executor.status_manager ..... SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS src.test.python.apache.thermos.cli.common ..... SUCCESS src.test.python.apache.thermos.cli.main ..... SUCCESS src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS FAILURE  FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 17, 2015, 11:54 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32171/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 11:54 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-1168 > https://issues.apache.org/jira/browse/AURORA-1168 > > > Repository: aurora > > > Description > ------- > > NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates. > > I'm open to input on this. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5 > src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a > > Diff: https://reviews.apache.org/r/32171/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============5222578445080992270==--