Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7050E174A7 for ; Mon, 16 Mar 2015 20:09:45 +0000 (UTC) Received: (qmail 75976 invoked by uid 500); 16 Mar 2015 20:09:45 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 75930 invoked by uid 500); 16 Mar 2015 20:09:45 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 75919 invoked by uid 99); 16 Mar 2015 20:09:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 20:09:45 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Mar 2015 20:09:43 +0000 Received: (qmail 75820 invoked by uid 99); 16 Mar 2015 20:09:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 20:09:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 58E541CF893; Mon, 16 Mar 2015 20:09:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7759927354562504729==" MIME-Version: 1.0 Subject: Re: Review Request 32078: Remove the populatedDEPRECATED thrift field. From: "Maxim Khutornenko" To: "Joshua Cohen" , "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora" Date: Mon, 16 Mar 2015 20:09:22 -0000 Message-ID: <20150316200922.392.87018@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32078/ X-Sender: "Maxim Khutornenko" References: <20150316173952.391.88228@reviews.apache.org> In-Reply-To: <20150316173952.391.88228@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7759927354562504729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76632 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On March 16, 2015, 5:39 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32078/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 5:39 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-975 > https://issues.apache.org/jira/browse/AURORA-975 > > > Repository: aurora > > > Description > ------- > > Remove the populatedDEPRECATED thrift field. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 8386ee36117c8135c7f855a496e1e887904b23dd > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 3876290c3c116ae29a0f386c899ea213efdba318 > src/main/python/apache/aurora/client/api/updater.py 7fd6fdacafb7c3d2b30e1d9de2c8a48a88e0e943 > src/main/python/apache/aurora/client/base.py 352d3f07148eff3c616f1f2dba861de6a023acc7 > src/main/python/apache/aurora/client/cli/jobs.py d6633d93a09f5203219d680cf3780ba1f17d0969 > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 3cf8dfde64d38d43e72dd1e7ccc901584b59cbe9 > src/test/python/apache/aurora/client/api/test_updater.py 7f3bc28aef52ed171a24ce2a98718afb6bfb1b54 > src/test/python/apache/aurora/client/cli/test_diff.py 054e6fbc1b1a56b4818b2a8f08b06e8c64bcfc10 > src/test/python/apache/aurora/client/cli/test_restart.py 4f20f6bf3db8d9cae35ec6458777990c763cdbd1 > src/test/python/apache/aurora/client/cli/test_update.py 9bfbbea85c6f123076fb570ea91d154dd11c2d78 > src/test/python/apache/aurora/client/test_base.py 06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4 > > Diff: https://reviews.apache.org/r/32078/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============7759927354562504729==--