Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F44210DE8 for ; Mon, 16 Mar 2015 18:59:45 +0000 (UTC) Received: (qmail 33222 invoked by uid 500); 16 Mar 2015 18:59:40 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 33170 invoked by uid 500); 16 Mar 2015 18:59:39 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 33158 invoked by uid 99); 16 Mar 2015 18:59:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 18:59:39 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Mar 2015 18:59:38 +0000 Received: (qmail 32640 invoked by uid 99); 16 Mar 2015 18:59:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 18:59:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BAAB31C069D; Mon, 16 Mar 2015 18:59:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8684397100512906499==" MIME-Version: 1.0 Subject: Re: Review Request 32118: Move creation of auth_module into ThriftAuthModule. From: "Bill Farner" To: "Joshua Cohen" , "Bill Farner" Cc: "Aurora" , "Kevin Sweeney" Date: Mon, 16 Mar 2015 18:59:17 -0000 Message-ID: <20150316185917.392.8769@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32118/ X-Sender: "Bill Farner" References: <20150316185437.391.54171@reviews.apache.org> In-Reply-To: <20150316185437.391.54171@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8684397100512906499== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/#review76613 ----------------------------------------------------------- Ship it! Ship It! - Bill Farner On March 16, 2015, 6:54 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32118/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 6:54 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1201 > https://issues.apache.org/jira/browse/AURORA-1201 > > > Repository: aurora > > > Description > ------- > > Move creation of auth_module into ThriftAuthModule. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/Modules.java e86e35f5435e7e83956fd80c8d3ae39eb50c9170 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c6f8787c894533327114425ba17bca966f07b554 > src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java e390af12669ac9464e2e7f6e9e1288136ed5ed9b > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java bb19fc72cafc1640f6331c5eaa3761da1a4af7c0 > > Diff: https://reviews.apache.org/r/32118/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Kevin Sweeney > > --===============8684397100512906499==--