Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0581A10594 for ; Mon, 16 Mar 2015 16:30:53 +0000 (UTC) Received: (qmail 39132 invoked by uid 500); 16 Mar 2015 16:30:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 39084 invoked by uid 500); 16 Mar 2015 16:30:52 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 39068 invoked by uid 99); 16 Mar 2015 16:30:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 16:30:52 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 16 Mar 2015 16:30:30 +0000 Received: (qmail 37574 invoked by uid 99); 16 Mar 2015 16:30:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Mar 2015 16:30:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 379EC1C069D; Mon, 16 Mar 2015 16:30:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3207574007022964672==" MIME-Version: 1.0 Subject: Re: Review Request 32106: Changed the updater to not update an instance if only the job owner changes From: "Maxim Khutornenko" To: "Bill Farner" Cc: "Aurora" , "Steve Niemitz" , "Maxim Khutornenko" Date: Mon, 16 Mar 2015 16:30:27 -0000 Message-ID: <20150316163027.392.2992@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/32106/ X-Sender: "Maxim Khutornenko" References: <20150316151346.391.5859@reviews.apache.org> In-Reply-To: <20150316151346.391.5859@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3207574007022964672== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32106/#review76568 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java There is actually a better place to do this type of action [1]. If not done there, the update will still have to iterate over all instances and generate a lot of instance event noise. Also, the UI will show these instances in the update working set, which does not reflect the NOOP nature of this action. [1] - https://github.com/apache/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java - Maxim Khutornenko On March 16, 2015, 3:13 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32106/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 3:13 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1200 > https://issues.apache.org/jira/browse/AURORA-1200 > > > Repository: aurora > > > Description > ------- > > Changed the updater to not update an instance if the job owner changes > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 14753cf5ef35d5133ca5029f3a465df884756070 > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 09c147e76d7c2c130a1fdd85459c45395fee7dde > > Diff: https://reviews.apache.org/r/32106/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > > --===============3207574007022964672==--