Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C810D10BC3 for ; Tue, 10 Mar 2015 01:00:45 +0000 (UTC) Received: (qmail 50252 invoked by uid 500); 10 Mar 2015 01:00:45 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 50206 invoked by uid 500); 10 Mar 2015 01:00:45 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 50195 invoked by uid 99); 10 Mar 2015 01:00:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2015 01:00:45 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 10 Mar 2015 01:00:23 +0000 Received: (qmail 49625 invoked by uid 99); 10 Mar 2015 01:00:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2015 01:00:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1AAAB1D3A4F; Tue, 10 Mar 2015 01:00:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0279454073498755962==" MIME-Version: 1.0 Subject: Re: Review Request 31814: Include messages with internal job updater state transitions. From: "Bill Farner" To: "Joshua Cohen" , "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora" Date: Tue, 10 Mar 2015 01:00:19 -0000 Message-ID: <20150310010019.17900.52046@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31814/ X-Sender: "Bill Farner" References: <20150310003537.17901.27775@reviews.apache.org> In-Reply-To: <20150310003537.17901.27775@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0279454073498755962== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75831 ----------------------------------------------------------- @ReviewBot retry - Bill Farner On March 10, 2015, 12:35 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31814/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 12:35 a.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1077 > https://issues.apache.org/jira/browse/AURORA-1077 > > > Repository: aurora > > > Description > ------- > > Include messages with internal job updater state transitions. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 09f2a74c9e6f6dbf79f83aa7a387587c593b9f0e > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 5d3b16a6e4f1d2af78ce70f85f6f0cc34829145f > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173 > src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 27e0654bfb90f48b407edda5a0c914e595d9c552 > src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 66b0e4b7a9b23e3e6c772a21f5adc39e1d1461ad > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 4db0080547d61af1511a4fb62bf88b3bbf819f1e > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 0fe153c75455fb9a42361f48ffc7c384b831bb0f > src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987 > > Diff: https://reviews.apache.org/r/31814/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============0279454073498755962==--