Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B66E10AE1 for ; Tue, 10 Mar 2015 00:37:46 +0000 (UTC) Received: (qmail 1113 invoked by uid 500); 10 Mar 2015 00:37:43 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 1072 invoked by uid 500); 10 Mar 2015 00:37:43 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 1061 invoked by uid 99); 10 Mar 2015 00:37:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2015 00:37:42 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 10 Mar 2015 00:37:41 +0000 Received: (qmail 234 invoked by uid 99); 10 Mar 2015 00:37:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2015 00:37:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E77041D3A4F; Tue, 10 Mar 2015 00:37:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0107969623182374097==" MIME-Version: 1.0 Subject: Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration From: "Kevin Sweeney" To: "Joshua Cohen" , "Bill Farner" Cc: "Aurora ReviewBot" , "Aurora" , "Zameer Manji" , "Kevin Sweeney" Date: Tue, 10 Mar 2015 00:37:19 -0000 Message-ID: <20150310003719.17900.47869@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31820/ X-Sender: "Kevin Sweeney" References: <20150307005447.12263.16185@reviews.apache.org> In-Reply-To: <20150307005447.12263.16185@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0107969623182374097== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/ ----------------------------------------------------------- (Updated March 9, 2015, 5:37 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes ------- Address review feedback. Bugs: AURORA-809 and AURORA-811 https://issues.apache.org/jira/browse/AURORA-809 https://issues.apache.org/jira/browse/AURORA-811 Repository: aurora Description ------- * Add dependency on Apache Shiro. * HTTP Basic Authentication. * Authorization based on shiro.ini. * Sample shiro.ini for local mode. Diffs (updated) ----- build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 3e7483b1e4e674397fd093f1e301d9cb2d3ca166 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 1e4ba014804b56a2ea02770d09beb63faaabf684 src/main/python/apache/aurora/common/clusters.py c4b7fefca30313b281808478bf23158a9b7fbf85 src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 640acdf4e73f99418473ca97bcdc4f5f4c190f10 src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroThriftInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52fe0ea063dbc7a71a20926630bf449dbd936306 src/test/python/apache/aurora/common/test_clusters.py 1bd696e9cd28d87d0cac68b33ab043407d796b61 src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-example.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-extra-sections.ini PRE-CREATION src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing ------- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney --===============0107969623182374097==--