Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BD6110F11 for ; Fri, 6 Mar 2015 23:09:09 +0000 (UTC) Received: (qmail 15491 invoked by uid 500); 6 Mar 2015 23:08:53 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 15440 invoked by uid 500); 6 Mar 2015 23:08:53 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 15428 invoked by uid 99); 6 Mar 2015 23:08:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 23:08:53 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 06 Mar 2015 23:08:30 +0000 Received: (qmail 14642 invoked by uid 99); 6 Mar 2015 23:08:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 23:08:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3252D1D3990; Fri, 6 Mar 2015 23:08:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7005755765956914632==" MIME-Version: 1.0 Subject: Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey. From: "Aurora ReviewBot" To: "Maxim Khutornenko" , "Joshua Cohen" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Fri, 06 Mar 2015 23:08:26 -0000 Message-ID: <20150306230826.5896.81039@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31779/ X-Sender: "Aurora ReviewBot" References: <20150306223846.12263.5125@reviews.apache.org> In-Reply-To: <20150306223846.12263.5125@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7005755765956914632== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31779/#review75565 ----------------------------------------------------------- Ship it! Master (8e71b58) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 6, 2015, 10:38 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31779/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 10:38 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1093 > https://issues.apache.org/jira/browse/AURORA-1093 > > > Repository: aurora > > > Description > ------- > > This was overlooked in AURORA-1093. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8ec5f9a3810b4deae981988487c6a46a20db72a2 > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 5989a62f1651aede6e2372ad3f519a9a947470de > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java acdade3dca807a221b4da975d0310c91884ee752 > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f > src/main/python/apache/aurora/client/api/__init__.py c07122744e89fe61dbe4bea0c14400425983b2ef > src/main/python/apache/aurora/client/cli/__init__.py 2e996775c7be460555b0a59b98441e01513f69c4 > src/main/python/apache/aurora/client/cli/update.py a4890057b7d258926bc3dfb84fd1248e68051f31 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 824740856236976984d2114ec6a6aea989a87d1e > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 459f745cec1f85ece41376cade39c09254b50013 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7ebc4d4642df107356ffbafabc25b560409022d7 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e24d6bde5f3479a75522e825cce4ec6c30c117aa > src/test/python/apache/aurora/client/api/test_api.py 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 > src/test/python/apache/aurora/client/cli/test_create.py a65aab71ee8ce19dc2c05ea230258084d6f55727 > src/test/python/apache/aurora/client/cli/test_quota.py c8d217da005afe7f65a8215882a5a119d4899b98 > src/test/python/apache/aurora/client/cli/test_restart.py b596babc3c6877f68094943126b8cd49be3fc635 > src/test/python/apache/aurora/client/cli/test_supdate.py 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 > src/test/python/apache/aurora/client/cli/util.py 6d3cc51f50b417405549c254531c854565a54949 > > Diff: https://reviews.apache.org/r/31779/diff/ > > > Testing > ------- > > Normal test suite + end-to-end tests. > > > Thanks, > > Bill Farner > > --===============7005755765956914632==--