Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3172110F9F for ; Thu, 5 Mar 2015 22:55:47 +0000 (UTC) Received: (qmail 71518 invoked by uid 500); 5 Mar 2015 22:55:47 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 71470 invoked by uid 500); 5 Mar 2015 22:55:47 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 71459 invoked by uid 99); 5 Mar 2015 22:55:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 22:55:46 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 05 Mar 2015 22:55:45 +0000 Received: (qmail 70106 invoked by uid 99); 5 Mar 2015 22:55:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 22:55:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EE44D1D38E5; Thu, 5 Mar 2015 22:55:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2490097387558739792==" MIME-Version: 1.0 Subject: Re: Review Request 31754: Break out API servlet configuration into its own module. From: "Aurora ReviewBot" To: "Bill Farner" , "Joshua Cohen" Cc: "Aurora ReviewBot" , "Aurora" , "Kevin Sweeney" Date: Thu, 05 Mar 2015 22:55:23 -0000 Message-ID: <20150305225523.12262.93517@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31754/ X-Sender: "Aurora ReviewBot" References: <20150305200351.5896.91042@reviews.apache.org> In-Reply-To: <20150305200351.5896.91042@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2490097387558739792== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/#review75404 ----------------------------------------------------------- This patch does not apply cleanly on master (70494a1), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 5, 2015, 8:03 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31754/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 8:03 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Break out API servlet configuration into its own module. > > This is necessary to make a follow-up patch introducing HTTP Basic auth testable. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 8a59d89c07b406ce98076ca7ee51b958599a39ec > src/main/java/org/apache/aurora/scheduler/http/SchedulerAPIServlet.java 33ad43b3202e5e9ef5be919b6abc5cbc7f62b660 > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java d1ab9b18394ad37fe9dcb131816fcfb2952bf8b6 > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 9804bf5549cd2589fc68c57b3895efd89923169b > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 8ec5f9a3810b4deae981988487c6a46a20db72a2 > src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 80beb258d9f2786668d29db85b1295163a402d42 > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 47d54e3c3bb1ba5e0fb26379792f515f25316480 > src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 5019094333f9807c64a49c29569ade191ee61824 > src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java PRE-CREATION > > Diff: https://reviews.apache.org/r/31754/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Sweeney > > --===============2490097387558739792==--