aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@apache.org>
Subject Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.
Date Mon, 23 Mar 2015 17:45:22 GMT


> On March 23, 2015, 5:43 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77
> > <https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77>
> >
> >     This method also appears to be used here: https://github.com/apache/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java#L81

Nevermind, RB is hiding the override. *whew* was questioning my sanity.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77424
-----------------------------------------------------------


On March 22, 2015, 6:37 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32377/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 6:37 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-1217
>     https://issues.apache.org/jira/browse/AURORA-1217
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an indirection for modules that must not be statically instantiated.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/Modules.java e95cb2a255e6986e0678a4085036deb24f9cb359

>   src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
cc9cfd38239f909b8a77bd1a773e31ec30130d41 
>   src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message