aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
Date Fri, 20 Mar 2015 20:23:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/
-----------------------------------------------------------

(Updated March 20, 2015, 8:23 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Updated doc.


Bugs: AURORA-1206
    https://issues.apache.org/jira/browse/AURORA-1206


Repository: aurora


Description
-------

One change i snuck in here is in `cli/__init__.py`.  This makes the subcommand help include
the the description:

```
$ aurora update info -h
usage: aurora update info [-h] [--write-json] [--verbose]
                          [--skip-hooks hook,hook,...]
                          CLUSTER/ROLE/ENV/NAME [ID]

Display detailed status information about a scheduler-driven in-progress
update. If no update ID is provided, information will be displayed about the
active update for the job.

positional arguments:
  CLUSTER/ROLE/ENV/NAME
                        Fully specified job key, in CLUSTER/ROLE/ENV/NAME
                        format
  ID                    Update identifier provided by the scheduler when an
                        update was started.

optional arguments:
  -h, --help            show this help message and exit
  --write-json          Generate command output in JSON format
  --verbose, -v         Show verbose output
  --skip-hooks hook,hook,...
                        A comma-separated list of command hook names that
                        should be skipped. If the hooks cannot be skipped,
                        then the command will be aborted
```

Prior to this change, the description was only displayed in the parent command's help text.


Diffs (updated)
-----

  docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab 
  src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d

  src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200

  src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104


Diff: https://reviews.apache.org/r/32313/diff/


Testing
-------

I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration
testing, which removed a ton of boilerplate.

I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently
fail.


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message