aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Pfeiffer" <apacherevi...@x8s.de>
Subject Re: Review Request 32231: AURORA-1189: Adding check to see if java version is below 1.8
Date Fri, 20 Mar 2015 16:36:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/
-----------------------------------------------------------

(Updated March 20, 2015, 4:36 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

removed the comment


Bugs: AURORA-1189
    https://issues.apache.org/jira/browse/AURORA-1189


Repository: aurora


Description
-------

AURORA-1189: Adding check to see if java version is below 1.8

I think it should be fine to check the java version that naive (comparing the char at 3rd
posion of java.version) since this check will probably already be removed again until java
1.10 comes out.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 66fb432028c26ea9ed8da475da6c3cbee5e535fc


Diff: https://reviews.apache.org/r/32231/diff/


Testing
-------

* ./gradlew test
* running scheduler on vagrant machine to check if log message appears
* couldn't get the scheduler run properly on java 1.8 to check if the message doesn't appear
there


Thanks,

Florian Pfeiffer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message