aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 32231: AURORA-1189: Adding check to see if java version is below 1.8
Date Fri, 20 Mar 2015 15:13:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/#review77222
-----------------------------------------------------------

Ship it!


Cool, spun this up in vagrant and confirmed:
```
W0320 15:08:49.773 THREAD1 org.apache.aurora.scheduler.app.SchedulerMain.run:
**************************************************************************
*
*
*       Beginning with Aurora 0.9.0, you'll need Java 1.8 to run aurora!
*       Currently you're running "1.7.0_75"
*
*
**************************************************************************
```

Just one nit, i'll put this on master after the diff is updated.


src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
<https://reviews.apache.org/r/32231/#comment125098>

    Remove this, the code below stands well enough on its own.


- Bill Farner


On March 19, 2015, 9:36 p.m., Florian Pfeiffer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32231/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 9:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1189
>     https://issues.apache.org/jira/browse/AURORA-1189
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1189: Adding check to see if java version is below 1.8
> 
> I think it should be fine to check the java version that naive (comparing the char at
3rd posion of java.version) since this check will probably already be removed again until
java 1.10 comes out.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 66fb432028c26ea9ed8da475da6c3cbee5e535fc

> 
> Diff: https://reviews.apache.org/r/32231/diff/
> 
> 
> Testing
> -------
> 
> * ./gradlew test
> * running scheduler on vagrant machine to check if log message appears
> * couldn't get the scheduler run properly on java 1.8 to check if the message doesn't
appear there
> 
> 
> Thanks,
> 
> Florian Pfeiffer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message