aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 32302: Allow config to specify static ports for non-dedicated jobs.
Date Fri, 20 Mar 2015 13:01:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32302/#review77213
-----------------------------------------------------------

Ship it!


Master (db79418) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 20, 2015, 12:30 p.m., Brian Brazil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32302/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 12:30 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1212
>     https://issues.apache.org/jira/browse/AURORA-1212
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Currently the client allows static ports only for dedicated jobs,
> the scheduler has no such restirction. Remove this restriction.
> 
> The docs make no mention of this limition, so no changes are
> required there.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 59703ef 
>   src/test/python/apache/aurora/client/test_config.py c567797 
> 
> Diff: https://reviews.apache.org/r/32302/diff/
> 
> 
> Testing
> -------
> 
> Ran unittests and created a non-dedicated job with a static port in vagrant enviroment.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message