aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 32171: Change "update list" subcommand to accept a hierarchy.
Date Tue, 17 Mar 2015 23:17:22 GMT


> On March 17, 2015, 10:59 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 267
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line267>
> >
> >     How about adding all statuses here to allow searching by a specific job update
status in addition to a group?

I considered that, but it makes for some pretty heinous help output.  I don't feel too strongly
either way, but i'm currently of the mindset that we can add it later without breaking compatibility.


> On March 17, 2015, 10:59 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 269
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line269>
> >
> >     typo

Fixed.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76836
-----------------------------------------------------------


On March 17, 2015, 8:50 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-1168
>     https://issues.apache.org/jira/browse/AURORA-1168
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change "update list" subcommand to accept a hierarchy.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5

>   src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a

> 
> Diff: https://reviews.apache.org/r/32171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message