aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 32181: Only warn about insufficient GC resources when actually needed
Date Tue, 17 Mar 2015 22:50:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32181/
-----------------------------------------------------------

(Updated March 17, 2015, 11:50 p.m.)


Review request for Aurora.


Summary (updated)
-----------------

Only warn about insufficient GC resources when actually needed


Repository: aurora


Description
-------

Only warn about insufficient GC resources when actually needed

Whenever a garbage collection run finishes, the launcher is offered the same resources again.
Probably due to rounding errors, these are not considered sufficient for another run. By changing
the order of time check and resource check we prevent unnecessary warnings about these small
offers.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 31aa2bbaab3d97875493ad75c4d2c7c82ac7fa58

  src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 422d5a9a42310979752eb7282658316c2b772419


Diff: https://reviews.apache.org/r/32181/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Stephan Erb


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message