aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <>
Subject Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.
Date Tue, 17 Mar 2015 19:18:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 17, 2015, 12:18 p.m.)

Review request for Aurora, Joshua Cohen and Bill Farner.


Remove @Inherited, which is only defined to have any meaning for class annotations.

Bugs: AURORA-1187

Repository: aurora


Add an AnnotatedAuroraAdmin subclass for AuroraAdmin.Iface and change code to inherit from
it. This gives us a place to put annotations like the AuthorizingParam one introduced in this
review without needing to copy-paste them when we override a new method. A future diff will
use these annotations to determine which permission a method call needs by inspecting the
annotated parameter. I created a new interface to enable DRY - otherwise I'd need to annotate
both ForwardingThrift and SchedulerThriftInterface and keep them in sync.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/http/api/security/ PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/thrift/ c60d1e78e0f5c474ff0dcf6393e0c305d865bded

  src/main/java/org/apache/aurora/scheduler/thrift/ b1d633602f3fb021a026a087b91d41580798eeaf

  src/main/java/org/apache/aurora/scheduler/thrift/aop/ PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/http/api/security/ f0e40b646092e96955fddc46c3a1e62a8237b00f

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ df6b53a524b005cd5fabb099fd0c08d83e3b287d

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ ee98f66de7f671018fa0a0b4894f114c7a283eda

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ 3900c2228038668576cdbb37e87127246a33317c

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ 7b1bf2ef8b413d2c1a08b41722a04af091305304

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ 7e20aaa6836bd205261afe5b1244fb6af8a56356




./gradlew build


Kevin Sweeney

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message