aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.
Date Tue, 17 Mar 2015 18:55:10 GMT


> On March 17, 2015, 9:31 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java,
line 60
> > <https://reviews.apache.org/r/32141/diff/1/?file=897132#file897132line60>
> >
> >     What's the guidance behind usage of @Nullable here? Technically, the `shardsId`
could come as NULL from thrift as well as `TaskQuery` in `killTasks`. Both are required for
RPC operation but the latter one is annotated with @Nullable.

This is a good point - I was mistaken about the codegen's handling of null collection types.
Added Nullable here as well.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141/#review76741
-----------------------------------------------------------


On March 16, 2015, 6:29 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32141/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 6:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1187
>     https://issues.apache.org/jira/browse/AURORA-1187
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an AnnotatedAuroraAdmin subclass for AuroraAdmin.Iface and change code to inherit
from it. This gives us a place to put annotations like the AuthorizingParam one introduced
in this review without needing to copy-paste them when we override a new method. A future
diff will use these annotations to determine which permission a method call needs by inspecting
the annotated parameter. I created a new interface to enable DRY - otherwise I'd need to annotate
both ForwardingThrift and SchedulerThriftInterface and keep them in sync.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded

>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf

>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java f0e40b646092e96955fddc46c3a1e62a8237b00f

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java df6b53a524b005cd5fabb099fd0c08d83e3b287d

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptorTest.java
ee98f66de7f671018fa0a0b4894f114c7a283eda 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 3900c2228038668576cdbb37e87127246a33317c

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 7b1bf2ef8b413d2c1a08b41722a04af091305304

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
7e20aaa6836bd205261afe5b1244fb6af8a56356 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java
aae5cd7709abe3896c2ae06c218a0c90ca11c576 
> 
> Diff: https://reviews.apache.org/r/32141/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message