aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions
Date Fri, 13 Mar 2015 19:34:34 GMT


> On March 13, 2015, 1:10 a.m., Brian Wickman wrote:
> > @ReviewBot retry
> 
> Bill Farner wrote:
>     If you believe you have discovered a flaky test (which i assume you're asking the
bot to try again), can you please file a ticket?

Not a flaky test -- a legitimate breakage that I did not anticipate.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76322
-----------------------------------------------------------


On March 13, 2015, 12:47 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32012/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 12:47 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We found that the new observer burns 10x the cpu in production.  Most of the time is
spent in compiling new regular expressions, so memoize them.  Follow-up review adds TaskDetector
caching in observer.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/common/path.py 4359a5143551fff3cf66e39e68ba9ba02b8d6e2e

>   src/main/python/apache/thermos/monitoring/detector.py e0922e61ef03fc578988f992aba46570ea1b5d6c

>   src/test/python/apache/thermos/monitoring/BUILD 4e99da403f322940579fd4f9412e022df0790884

>   src/test/python/apache/thermos/monitoring/test_detector.py e9005c402ec81bbb415d9c814aa7b4e759138304

> 
> Diff: https://reviews.apache.org/r/32012/diff/
> 
> 
> Testing
> -------
> 
> Added generic TaskDetector test and made sure it passes before/after.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message