aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 32013: Cache TaskDetectors for reuse.
Date Fri, 13 Mar 2015 00:58:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76318
-----------------------------------------------------------


Master (ee1a13a) is red with this patch.
  ./build-support/jenkins/build.sh

                     plugins: cov, timeout
                     
                     collecting 0 items
                     collecting 1 items
                     collected 1 items 
                     
                     src/test/python/apache/aurora/executor/common/test_path_detector.py::test_path_detector
FAILED
                     
                     ==================== FAILURES ====================
                     _______________ test_path_detector _______________
                     
                         def test_path_detector():
                           ROOTS = ('/var/lib/mesos1/slaves', '/var/lib/mesos2/slaves')
                           FAKE_ROOT = '/var/blah/blah'
                           FAKE_CHECKPOINT_DIR = 'ckpt'
                         
                           path1, path2 = (
                               ExecutorDetector.path(Match(ROOTS[0], 'slave001', 'framework1',
'executor1', 'latest')),
                               ExecutorDetector.path(Match(ROOTS[1], 'slave002', 'framework2',
'executor2', 'latest')),
                           )
                         
                           with mock.patch('glob.glob', return_value=(path1, path2)) as
glob:
                             mpd = MesosPathDetector(root=FAKE_ROOT, sandbox_path=FAKE_CHECKPOINT_DIR)
                             paths = list(mpd.get_paths())
                     >       assert len(paths) == 2
                     E       assert 0 == 2
                     E        +  where 0 = len([])
                     
                     src/test/python/apache/aurora/executor/common/test_path_detector.py:45:
AssertionError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.executor.common.path_detector.xml

                     ============ 1 failed in 0.06 seconds ============
                     src.test.python.apache.aurora.client.hooks.non_hooked_api           
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.path_detector         
           .....   FAILURE
                     src.test.python.apache.thermos.cli.commands.commands                
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.common                           
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.main                             
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                 
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                 
           .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 13, 2015, 12:48 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32013/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 12:48 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> SSIA
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/path_detector.py e4135cca09b43e204c52774b747f74212d0a5732

>   src/main/python/apache/thermos/observer/detector.py 5347cded7061b085b135d62fdb3a5c4a75f81e5c

> 
> Diff: https://reviews.apache.org/r/32013/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/observer:: + manual observation
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message