aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 31966: Add client support for including messages when changing update state.
Date Thu, 12 Mar 2015 16:23:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/api/__init__.py
<https://reviews.apache.org/r/31966/#comment123752>

    Spacing seems off here and below.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123755>

    I'd also include a short '-m' name to make typing less tedious.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123753>

    While not entirely consistent, the majority of our CommandOption help strings start with
a capital.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/31966/#comment123754>

    Mind sorting them alphabetically?


- Maxim Khutornenko


On March 12, 2015, 1:27 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31966/
> -----------------------------------------------------------
> 
> (Updated March 12, 2015, 1:27 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1077
>     https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> More plumbing.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd

>   src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae

>   src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635

>   src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb

>   src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c

>   src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61

> 
> Diff: https://reviews.apache.org/r/31966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message