aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31869: Catch only known Exception types in the client.
Date Tue, 10 Mar 2015 17:44:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
-----------------------------------------------------------

(Updated March 10, 2015, 5:44 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Bugs: AURORA-1176
    https://issues.apache.org/jira/browse/AURORA-1176


Repository: aurora


Description
-------

As indicated by some changes in tests - there were legitimate issues hiding behind this catch.
 After this change, the client will allow unhandled exceptions to surface in their full glory.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/__init__.py 194629f61192c1d7d5e7064e9226adf26d03e890

  src/main/python/apache/aurora/client/cli/__init__.py 4d9ef09749e3075b9d9e2ae1db311e60f7bdb4ee

  src/main/python/apache/aurora/client/cli/jobs.py 286b2182d5fe25703882f0b367739ad03d6c8fe8

  src/test/python/apache/aurora/client/cli/test_api_from_cli.py b855c3c2d74125738d2106e18a9e9b0ebed6ac4b

  src/test/python/apache/aurora/client/cli/test_create.py 459d157155f74b6a3d140bcccc85d3b7f0364367

  src/test/python/apache/aurora/client/cli/test_kill.py 7aad34a2fe5591937c5bca890751073439e3a1a6

  src/test/python/apache/aurora/client/cli/test_supdate.py 1806769426a196793481f948892f5474df8dd665

  src/test/python/apache/aurora/client/cli/util.py b65970a2717a1f36767c61e5e09c980b04895f01


Diff: https://reviews.apache.org/r/31869/diff/


Testing
-------


Thanks,

Bill Farner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message