aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua Cohen" <jco...@twopensource.com>
Subject Re: Review Request 31814: Include messages with internal job updater state transitions.
Date Sat, 07 Mar 2015 00:01:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814/#review75573
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
<https://reviews.apache.org/r/31814/#comment122760>

    nit: s/>p/<p



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
<https://reviews.apache.org/r/31814/#comment122762>

    The original scope for AURORA-1077 was to allow for passing a message along with pause/abort
RPCs (so we can, e.g., associate some additional data with a pause caused by an external service
monitoring an update).
    
    Unless I'm missing something, I don't see that support here. Is that planned for a subsequent
review, or has that requirement been missed?



src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java
<https://reviews.apache.org/r/31814/#comment122761>

    restore newline, remove leading space.


- Joshua Cohen


On March 6, 2015, 11:29 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31814/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 11:29 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1077
>     https://issues.apache.org/jira/browse/AURORA-1077
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Include messages with internal job updater state transitions.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 09f2a74c9e6f6dbf79f83aa7a387587c593b9f0e

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java acdade3dca807a221b4da975d0310c91884ee752

>   src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java 27a5b9026f5ac3b3bdeb32813b10435bc3dab173

>   src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 27e0654bfb90f48b407edda5a0c914e595d9c552

>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 66b0e4b7a9b23e3e6c772a21f5adc39e1d1461ad

>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 4db0080547d61af1511a4fb62bf88b3bbf819f1e

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e24d6bde5f3479a75522e825cce4ec6c30c117aa

>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987

> 
> Diff: https://reviews.apache.org/r/31814/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message