aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.
Date Tue, 03 Mar 2015 22:28:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75065
-----------------------------------------------------------


Master (2bf03dc) is red with this patch.
  ./build-support/jenkins/build.sh

                     src.test.python.apache.aurora.executor.common.directory_sandbox     
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.executor_detector     
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.executor_timeout      
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.health_checker        
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.kill_manager          
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.path_detector         
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.resource_manager_integration
     .....   FAILURE
                     src.test.python.apache.aurora.executor.common.status_checker        
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.task_info             
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_base                
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_vars                
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.gc_executor                  
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.status_manager               
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.thermos_executor             
           .....   SUCCESS
                     src.test.python.apache.aurora.executor.thermos_task_runner          
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.commands.commands                
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.common                           
           .....   SUCCESS
                     src.test.python.apache.thermos.cli.main                             
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                 
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_planner                  
           .....   SUCCESS
                     src.test.python.apache.thermos.common.test_task_planner             
           .....   SUCCESS
                     src.test.python.apache.thermos.config.test_schema                   
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_angry                      
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_ephemerals                 
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_failing_runner             
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_failure_limit              
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_finalization               
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_helper                     
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_process                    
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_runner_integration         
           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_staged_kill                
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_detector             
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                 
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_garbage              
           .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_resource             
           .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 10:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
>     https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that we can easily
add a customized aurora entry point for thermos that is capable of finding checkpoint roots
in executor sandboxes.  Added said entry point in src/main/apache/aurora/tools/thermos.py
-- open for other suggestions where this should live (possibly under aurora/executor/bin?)
 This is a drop-in replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed in gc, status
and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not go with
full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda

>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20

>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message