aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31659: Clean up end-to-end tests.
Date Tue, 03 Mar 2015 20:34:35 GMT


> On March 3, 2015, 5:23 p.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 64
> > <https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line64>
> >
> >     Is this statement still accurate now that ssh is dropped from the command?

It is not!  Thanks, removed.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review74983
-----------------------------------------------------------


On March 3, 2015, 3:23 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31659/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 3:23 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Major changes:
> - applying DRY by not invoking everything via `vagrant ssh` (making tests easier to write
and much faster to run)
> - pulled 'test cases' into individual functions
> - simplified (maybe?) setup for tests using SSH
> 
> This is being done in preparation for AURORA-1157.
> 
> 
> Diffs
> -----
> 
>   src/test/sh/org/apache/aurora/e2e/test_common.sh b621975bab6f8bbf193e61360654e34337e36943

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1d599c3f71b7e07c1cb8bee01a4d3b5cfcf92631

>   src/test/sh/org/apache/aurora/e2e/test_run.sh ab91b95a60f7b459b95dc7e13a29692badca5ff7

> 
> Diff: https://reviews.apache.org/r/31659/diff/
> 
> 
> Testing
> -------
> 
> Ran the script.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message