aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.
Date Tue, 03 Mar 2015 18:30:54 GMT


> On March 3, 2015, 6:28 p.m., Aurora ReviewBot wrote:
> > Master (782e3e7) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                      src.test.python.apache.aurora.client.cli.update           
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.cli.version          
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.config               
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.factory              
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.hooks.hooked_api     
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.client.hooks.non_hooked_api 
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_aurora_job_key  
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_cluster         
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_cluster_option  
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_clusters        
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_http_signaler   
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_pex_version     
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_shellify        
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.common.test_transport       
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.config.test_base            
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.config.test_constraint_parsing
                   .....   SUCCESS
> >                      src.test.python.apache.aurora.config.test_loader          
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.config.test_thrift          
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.announcer   
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.directory_sandbox
                .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.executor_detector
                .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.executor_timeout
                 .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.health_checker
                   .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.kill_manager
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.path_detector
                    .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.status_checker
                   .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.common.task_info   
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.executor_base      
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.executor_vars      
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.gc_executor        
                     .....   FAILURE
> >                      src.test.python.apache.aurora.executor.status_manager     
                     .....   SUCCESS
> >                      src.test.python.apache.aurora.executor.thermos_task_runner
                     .....   SUCCESS
> >                      src.test.python.apache.thermos.common.test_pathspec       
                     .....   SUCCESS
> >                      src.test.python.apache.thermos.core.test_runner_integration
                    .....   SUCCESS
> >                      src.test.python.apache.thermos.monitoring.test_disk       
                     .....   SUCCESS
> >                      
> > FAILURE
> > 
> > 
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

Whack-a-mole https://issues.apache.org/jira/browse/AURORA-1162


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review75003
-----------------------------------------------------------


On March 3, 2015, 3:23 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 3:23 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
>     https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths from the
slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to get this out
first since more people want it.  I'll implement per-job mounts in a future review.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift a5198dfe1c56e05d50e32dd14222a984515c0d07

>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 3239eaa139e35e8c3acdacf6375f492de2b5bfee

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 24b61c1e4f615295acf28d904588e1512972d3f4

>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java baacb71403d55c5b90fc11cb2a23f552a32e8ba5

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5340d651b298ec8aa079e73d6d2f652fdf876293

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6575b7d420f17ec68d6e2a83e7b380f684577d4f

>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898

>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc

> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message