Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A282104DA for ; Fri, 27 Feb 2015 20:20:39 +0000 (UTC) Received: (qmail 36096 invoked by uid 500); 27 Feb 2015 20:20:38 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 36047 invoked by uid 500); 27 Feb 2015 20:20:38 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 36036 invoked by uid 99); 27 Feb 2015 20:20:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2015 20:20:38 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Feb 2015 20:20:37 +0000 Received: (qmail 35952 invoked by uid 99); 27 Feb 2015 20:20:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2015 20:20:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E59541D3281; Fri, 27 Feb 2015 20:20:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1557767047623370986==" MIME-Version: 1.0 Subject: Re: Review Request 31558: Removing --rollback-on-failure from aurora restart. From: "Zameer Manji" To: "Zameer Manji" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 27 Feb 2015 20:20:16 -0000 Message-ID: <20150227202016.1421.60522@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31558/ X-Sender: "Zameer Manji" References: <20150227201330.1420.53248@reviews.apache.org> In-Reply-To: <20150227201330.1420.53248@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1557767047623370986== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31558/#review74573 ----------------------------------------------------------- Ship it! Just to be clear, this is because it doesn't make sense to have rollback with restarts right? - Zameer Manji On Feb. 27, 2015, 12:13 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31558/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 12:13 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1020 > https://issues.apache.org/jira/browse/AURORA-1020 > > > Repository: aurora > > > Description > ------- > > Removing --rollback-on-failure from aurora restart. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92 > src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51 > > Diff: https://reviews.apache.org/r/31558/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all > > > Thanks, > > Maxim Khutornenko > > --===============1557767047623370986==--