Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5901617E92 for ; Fri, 27 Feb 2015 18:40:52 +0000 (UTC) Received: (qmail 15693 invoked by uid 500); 27 Feb 2015 18:40:47 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 15645 invoked by uid 500); 27 Feb 2015 18:40:47 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 15634 invoked by uid 99); 27 Feb 2015 18:40:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2015 18:40:46 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Feb 2015 18:40:45 +0000 Received: (qmail 15508 invoked by uid 99); 27 Feb 2015 18:40:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2015 18:40:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ADB1D1CC037; Fri, 27 Feb 2015 18:40:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0821155092633363160==" MIME-Version: 1.0 Subject: Re: Review Request 31550: Add test coverage for MesosSchedulerImpl. From: "Aurora ReviewBot" To: "Maxim Khutornenko" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Fri, 27 Feb 2015 18:40:24 -0000 Message-ID: <20150227184024.1420.4642@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31550/ X-Sender: "Aurora ReviewBot" References: <20150227183033.1421.91772@reviews.apache.org> In-Reply-To: <20150227183033.1421.91772@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0821155092633363160== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31550/#review74536 ----------------------------------------------------------- Master (d1a1296) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.cron ..... SUCCESS src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS src.test.python.apache.aurora.client.cli.job ..... SUCCESS src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS src.test.python.apache.aurora.client.cli.quota ..... SUCCESS src.test.python.apache.aurora.client.cli.sla ..... SUCCESS src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS src.test.python.apache.aurora.client.cli.task ..... SUCCESS src.test.python.apache.aurora.client.cli.update ..... SUCCESS src.test.python.apache.aurora.client.cli.version ..... SUCCESS src.test.python.apache.aurora.client.config ..... SUCCESS src.test.python.apache.aurora.client.factory ..... SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS src.test.python.apache.aurora.common.test_cluster ..... SUCCESS src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS src.test.python.apache.aurora.common.test_clusters ..... SUCCESS src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS src.test.python.apache.aurora.common.test_shellify ..... SUCCESS src.test.python.apache.aurora.common.test_transport ..... SUCCESS src.test.python.apache.aurora.config.test_base ..... SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS src.test.python.apache.aurora.config.test_loader ..... SUCCESS src.test.python.apache.aurora.config.test_thrift ..... SUCCESS src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS src.test.python.apache.aurora.executor.executor_base ..... SUCCESS src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS src.test.python.apache.aurora.executor.status_manager ..... SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS FAILURE  FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31550/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 6:30 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > This brings MesosSchedulerImpl to 100% line and branch coverage. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd > > Diff: https://reviews.apache.org/r/31550/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============0821155092633363160==--