Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E969710A0D for ; Thu, 26 Feb 2015 20:50:28 +0000 (UTC) Received: (qmail 10641 invoked by uid 500); 26 Feb 2015 20:50:28 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10591 invoked by uid 500); 26 Feb 2015 20:50:28 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 10580 invoked by uid 99); 26 Feb 2015 20:50:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 20:50:28 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 26 Feb 2015 20:50:27 +0000 Received: (qmail 10210 invoked by uid 99); 26 Feb 2015 20:50:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 20:50:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D4FAE1D22F1; Thu, 26 Feb 2015 20:50:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3815110202301151848==" MIME-Version: 1.0 Subject: Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector. From: "Joshua Cohen" To: "Stephan Erb" , "Joshua Cohen" Cc: "Brian Wickman" , "Aurora" Date: Thu, 26 Feb 2015 20:50:06 -0000 Message-ID: <20150226205006.1421.17934@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31491/ X-Sender: "Joshua Cohen" References: <20150226200045.1420.68988@reviews.apache.org> In-Reply-To: <20150226200045.1420.68988@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3815110202301151848== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74362 ----------------------------------------------------------- Ship it! Ship It! - Joshua Cohen On Feb. 26, 2015, 8 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31491/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 8 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1155 > https://issues.apache.org/jira/browse/AURORA-1155 > > > Repository: aurora > > > Description > ------- > > Add basic test coverage to the TaskGarbageCollector. > > > Diffs > ----- > > src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe > src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 > src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION > > Diff: https://reviews.apache.org/r/31491/diff/ > > > Testing > ------- > > ./pants test src/test/python/apache/thermos/monitoring:test_garbage > > > Thanks, > > Brian Wickman > > --===============3815110202301151848==--