Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1817117D8B for ; Thu, 26 Feb 2015 02:15:19 +0000 (UTC) Received: (qmail 23486 invoked by uid 500); 26 Feb 2015 02:15:18 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 23436 invoked by uid 500); 26 Feb 2015 02:15:18 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 23425 invoked by uid 99); 26 Feb 2015 02:15:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 02:15:18 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 26 Feb 2015 02:15:16 +0000 Received: (qmail 23319 invoked by uid 99); 26 Feb 2015 02:14:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 02:14:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 559641D32D7; Thu, 26 Feb 2015 02:14:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9161452273604575385==" MIME-Version: 1.0 Subject: Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id. From: "Aurora ReviewBot" To: "Maxim Khutornenko" , "Zameer Manji" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Thu, 26 Feb 2015 02:14:56 -0000 Message-ID: <20150226021456.1421.26951@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31388/ X-Sender: "Aurora ReviewBot" References: <20150226013938.1421.55074@reviews.apache.org> In-Reply-To: <20150226013938.1421.55074@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============9161452273604575385== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74190 ----------------------------------------------------------- Ship it! Master (9442e08) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 26, 2015, 1:39 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31388/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 1:39 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1093 > https://issues.apache.org/jira/browse/AURORA-1093 > > > Repository: aurora > > > Description > ------- > > Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id. > > Note: This change will leave the client in a broken state w.r.t. the scheduler. I will hold commiting this change until i have another review ready to go that updates the client. > > TODO: Update javascript uses of the API > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279 > https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174 > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 6a00ce2c30ce24851560c4d499c395194dbeed16 > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 8444d225e91c75e9a571049d28af7264b6d2d017 > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6ade817284b4c0607fe1ff09ad61ea47768f7297 > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 06de5384182f84f973a28e312c0dc4329f593dad > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java b9dce16fa705fc14b5af394f8edb6301c789aff4 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 56398f33206cfa1fa45601a21760c7e23e2616bf > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java d1bd3c975b2057b46597f38555c2a73d14835600 > src/main/java/org/apache/aurora/scheduler/updater/Updates.java b8c919585307e27f154782ee179153165458bed7 > src/main/python/apache/aurora/client/api/__init__.py 07d1b1c5405b1329a15e8900b07c2a3dba6c592f > src/main/python/apache/aurora/client/cli/context.py ea64010ab20c1292fb3fd1f5eb71394b7c965743 > src/main/python/apache/aurora/client/cli/update.py bfa7a27c4e283b981a4ce37d382aa117a0074ee1 > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml c08f09a511e1fc631abdae50630b8b7ab10a440b > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql e6184dd2de0e86849d811ec05c168bbb4db8e8cd > src/main/resources/scheduler/assets/breadcrumb.html b5f82ca120d3b76b63a61628437525cec8870015 > src/main/resources/scheduler/assets/job.html 4a00a8863d676f168fbfce9f45ec4bad0244199f > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b79b07c23e00fab524aef21481070c5f09c9fa18 > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 81c8be7685854c47ed4a7c6deeffb6a0b80023ab > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java e969b972806bef9aa67729c8a35283df6145e687 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d36418807ace4f61e8709a2827cea0e7bb8ac6b7 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2405bb8ad379e355a7987e9bb4163e1693f18777 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 3ba6274b97393ac2228d3eac8ba1615cb57014f8 > src/test/python/apache/aurora/client/api/test_api.py ff1aff2eac391f219bc7c2483a16e35f916a224c > src/test/python/apache/aurora/client/cli/test_status.py 1f39aa1c50a41e174804751b4cce25b96b6aebed > src/test/python/apache/aurora/client/cli/test_supdate.py 6413c0db20db5914c7b1537da2bbc6e110705dc2 > > Diff: https://reviews.apache.org/r/31388/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============9161452273604575385==--