Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9616417D13 for ; Thu, 26 Feb 2015 01:51:23 +0000 (UTC) Received: (qmail 634 invoked by uid 500); 26 Feb 2015 01:51:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 584 invoked by uid 500); 26 Feb 2015 01:51:23 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 573 invoked by uid 99); 26 Feb 2015 01:51:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 01:51:23 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 26 Feb 2015 01:51:21 +0000 Received: (qmail 99903 invoked by uid 99); 26 Feb 2015 01:51:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Feb 2015 01:51:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 116481D32D7; Thu, 26 Feb 2015 01:51:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3481704516039206818==" MIME-Version: 1.0 Subject: Re: Review Request 31451: Port thermos observer to the path detector interface From: "Brian Wickman" To: "Joe Smith" , "Zameer Manji" Cc: "Aurora" , "Brian Wickman" Date: Thu, 26 Feb 2015 01:51:01 -0000 Message-ID: <20150226015101.1420.74823@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31451/ X-Sender: "Brian Wickman" References: <20150226014434.1421.25003@reviews.apache.org> In-Reply-To: <20150226014434.1421.25003@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3481704516039206818== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 26, 2015, 1:44 a.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/task_observer.py, line 592 > > > > > > fix this. You should definitely be concerned about the current state of the observer. I've started a big refactor and some of the progress can be found here: https://github.com/apache/incubator-aurora/compare/master...wickman:wickman/AURORA-1026 It will substantially improve the test coverage for this code. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74184 ----------------------------------------------------------- On Feb. 26, 2015, 1:50 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31451/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 1:50 a.m.) > > > Review request for Aurora, Joe Smith and Zameer Manji. > > > Bugs: AURORA-1026 > https://issues.apache.org/jira/browse/AURORA-1026 > > > Repository: aurora > > > Description > ------- > > This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a > src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 > src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda > src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2 > src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7 > src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8 > src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 > src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f > src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138 > src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5 > src/main/python/apache/thermos/observer/detector.py PRE-CREATION > src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381 > src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 > src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886 > src/test/python/apache/thermos/observer/BUILD PRE-CREATION > src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION > > Diff: https://reviews.apache.org/r/31451/diff/ > > > Testing > ------- > > Manually launched observer and ran some thermos tasks. > + > mba=aurora=; ./pants test src/test/python/apache/thermos/observer/:: > > > Thanks, > > Brian Wickman > > --===============3481704516039206818==--