Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42C8017D87 for ; Wed, 25 Feb 2015 00:07:50 +0000 (UTC) Received: (qmail 3370 invoked by uid 500); 25 Feb 2015 00:07:50 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 3337 invoked by uid 500); 25 Feb 2015 00:07:50 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 3326 invoked by uid 99); 25 Feb 2015 00:07:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Feb 2015 00:07:49 +0000 X-ASF-Spam-Status: No, hits=-1996.7 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,TRACKER_ID,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 25 Feb 2015 00:07:44 +0000 Received: (qmail 3129 invoked by uid 99); 25 Feb 2015 00:07:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Feb 2015 00:07:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A0D311D3185; Wed, 25 Feb 2015 00:07:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3052160791900717843==" MIME-Version: 1.0 Subject: Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id. From: "Bill Farner" To: "Maxim Khutornenko" , "Zameer Manji" Cc: "Bill Farner" , "Aurora ReviewBot" , "Aurora" Date: Wed, 25 Feb 2015 00:07:21 -0000 Message-ID: <20150225000721.4175.39894@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31388/ X-Sender: "Bill Farner" References: <20150225000007.4175.65405@reviews.apache.org> In-Reply-To: <20150225000007.4175.65405@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3052160791900717843== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ ----------------------------------------------------------- (Updated Feb. 25, 2015, 12:07 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes ------- Rebase on master. Bugs: AURORA-1093 https://issues.apache.org/jira/browse/AURORA-1093 Repository: aurora Description ------- Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id. Note: This change will leave the client in a broken state w.r.t. the scheduler. I will hold commiting this change until i have another review ready to go that updates the client. Diffs (updated) ----- api/src/main/thrift/org/apache/aurora/gen/api.thrift 6a00ce2c30ce24851560c4d499c395194dbeed16 src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 199dc1123cd1966b1c8075e7a486efdf627c45f3 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java fc8e2f4e75a33789b28588204cbbfd56b5d049a4 src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 72b9895214aa372c4fd75e5bb6dee8485b3594f6 src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java b9dce16fa705fc14b5af394f8edb6301c789aff4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059626f742ce806fded754ef04a83e2eb5405ff2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java d1bd3c975b2057b46597f38555c2a73d14835600 src/main/java/org/apache/aurora/scheduler/updater/Updates.java b8c919585307e27f154782ee179153165458bed7 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml c08f09a511e1fc631abdae50630b8b7ab10a440b src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql e6184dd2de0e86849d811ec05c168bbb4db8e8cd src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b79b07c23e00fab524aef21481070c5f09c9fa18 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 81c8be7685854c47ed4a7c6deeffb6a0b80023ab src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java e969b972806bef9aa67729c8a35283df6145e687 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d36418807ace4f61e8709a2827cea0e7bb8ac6b7 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2405bb8ad379e355a7987e9bb4163e1693f18777 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 3ba6274b97393ac2228d3eac8ba1615cb57014f8 Diff: https://reviews.apache.org/r/31388/diff/ Testing ------- Thanks, Bill Farner --===============3052160791900717843==--