Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 234D717290 for ; Mon, 23 Feb 2015 18:54:10 +0000 (UTC) Received: (qmail 79168 invoked by uid 500); 23 Feb 2015 18:54:10 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 79118 invoked by uid 500); 23 Feb 2015 18:54:10 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 79107 invoked by uid 99); 23 Feb 2015 18:54:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Feb 2015 18:54:09 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Feb 2015 18:54:08 +0000 Received: (qmail 77636 invoked by uid 99); 23 Feb 2015 18:53:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Feb 2015 18:53:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 506531D2EB9; Mon, 23 Feb 2015 18:53:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0959838456558972229==" MIME-Version: 1.0 Subject: Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency. From: "Bill Farner" To: "Maxim Khutornenko" , "Joshua Cohen" Cc: "Bill Farner" , "Aurora" Date: Mon, 23 Feb 2015 18:53:46 -0000 Message-ID: <20150223185346.4175.60103@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31248/ X-Sender: "Bill Farner" References: <20150223182207.4175.45033@reviews.apache.org> In-Reply-To: <20150223182207.4175.45033@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0959838456558972229== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 23, 2015, 6:22 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, lines 199-201 > > > > > > Well, I think this is actually worse than it was. In case there is no StringBuilder concatenation active in JVM, this is still producing unnecessary string objects. However, in the opposite case, there will be muiltiple StringBuilder objects and heap churn may be even worse. > > > > Don't want to block review on this anymore but please, convert everything to a single StringBuilder without concatenation or revert back to concatenation to hopefully take advantage of an auto generated StringBuilder. Sorry, that was hasty, and i agree an odd use of StringBuilder. I will update to remove concatenation. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31248/#review73608 ----------------------------------------------------------- On Feb. 21, 2015, 6:33 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31248/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 6:33 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1028 > https://issues.apache.org/jira/browse/AURORA-1028 > > > Repository: aurora > > > Description > ------- > > Export stats for source and reason for LOST tasks, and status delivery latency. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 1d8f0128732756db74576ee669f6a2718fecc105 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java ffc30bb548706df7bec9e1502242890e9b5eb942 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java 59ad9e65589c421cefb76f265446fa2885e6198c > src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d02c6b32841d5d39c5780e7a044079a38729effb > src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/31248/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============0959838456558972229==--