Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============5375966637672396276=="
MIME-Version: 1.0
Subject: Re: Review Request 30647: Instrument the HealthChecker to export
 stats.
From: "Brian Wickman" <wickman@apache.org>
To: "Bill Farner" <wfarner@apache.org>,
 "Joshua Cohen" <jcohen@twopensource.com>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Brian Wickman" <wickman@apache.org>
Date: Fri, 20 Feb 2015 23:07:17 -0000
Message-ID: <20150220230717.21353.10756@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brian Wickman" <noreply@reviews.apache.org>
References: <20150220223000.21353.19695@reviews.apache.org>
In-Reply-To: <20150220223000.21353.19695@reviews.apache.org>
Reply-To: "Brian Wickman" <wickman@apache.org>

--===============5375966637672396276==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 136
> > <https://reviews.apache.org/r/30647/diff/8/?file=870602#file870602line136>
> >
> >     Is it necessary to use a real clock + real threads + sleeps in this test?  I'm not confident i can confirm that this test will not be flaky with these in place.

this is not a real clock.  it's a fake clock that allows us to test threaded behavior:

https://github.com/twitter/commons/blob/master/src/python/twitter/common/testing/clock.py


> On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 161
> > <https://reviews.apache.org/r/30647/diff/8/?file=870600#file870600line161>
> >
> >     nit - can you include the unit in the name?  i've seen time-based things misused more often than i care to recall

sure


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73324
-----------------------------------------------------------


On Feb. 20, 2015, 7:33 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 7:33 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
>     https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


--===============5375966637672396276==--