Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFF58104B9 for ; Fri, 20 Feb 2015 22:30:38 +0000 (UTC) Received: (qmail 77862 invoked by uid 500); 20 Feb 2015 22:30:38 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 77813 invoked by uid 500); 20 Feb 2015 22:30:38 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 77802 invoked by uid 99); 20 Feb 2015 22:30:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 22:30:38 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Feb 2015 22:30:37 +0000 Received: (qmail 74593 invoked by uid 99); 20 Feb 2015 22:29:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 22:29:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2B0D1D22EB; Fri, 20 Feb 2015 22:29:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0223735953347015931==" MIME-Version: 1.0 Subject: Review Request 31240: Remove render partial job key method. From: "Zameer Manji" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Zameer Manji" Date: Fri, 20 Feb 2015 22:29:00 -0000 Message-ID: <20150220222900.21353.39626@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31240/ X-Sender: "Zameer Manji" Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0223735953347015931== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31240/ ----------------------------------------------------------- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: aurora Description ------- This continues the refactoring started in https://reviews.apache.org/r/30207/ which will allow for easier testing and mocking out of the context object. This removes more single caller methods from the global context object and moves them closer to the callers. Diffs ----- src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf src/main/python/apache/aurora/client/cli/options.py 36f80aa175beaf8f2dc6b6f962394643313d6405 src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 Diff: https://reviews.apache.org/r/31240/diff/ Testing ------- ./pants test.pytest --no-fast src/test/python/apache/aurora/client:: Thanks, Zameer Manji --===============0223735953347015931==--