Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D0AC17DCA for ; Fri, 20 Feb 2015 19:33:50 +0000 (UTC) Received: (qmail 8505 invoked by uid 500); 20 Feb 2015 19:33:47 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 8457 invoked by uid 500); 20 Feb 2015 19:33:47 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 8438 invoked by uid 99); 20 Feb 2015 19:33:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 19:33:46 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Feb 2015 19:33:45 +0000 Received: (qmail 7607 invoked by uid 99); 20 Feb 2015 19:33:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 19:33:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 11CA61D2339; Fri, 20 Feb 2015 19:33:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3207393383832757344==" MIME-Version: 1.0 Subject: Re: Review Request 30647: Instrument the HealthChecker to export stats. From: "Brian Wickman" To: "Bill Farner" , "Joshua Cohen" Cc: "Joe Smith" , "Brian Wickman" , "Aurora" , "Aurora ReviewBot" , "Maxim Khutornenko" Date: Fri, 20 Feb 2015 19:33:22 -0000 Message-ID: <20150220193322.21353.62966@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30647/ X-Sender: "Brian Wickman" References: <20150218010058.21354.64558@reviews.apache.org> In-Reply-To: <20150218010058.21354.64558@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3207393383832757344== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ ----------------------------------------------------------- (Updated Feb. 20, 2015, 7:33 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Changes ------- Address Bill's feedback. Bugs: AURORA-1062 https://issues.apache.org/jira/browse/AURORA-1062 Repository: aurora Description ------- Instrument the HealthChecker to export stats. HealthChecker plugin now should export three stats: consecutive_failures: number of consecutive failures experienced (resets on success) latency: how long health checks are taking in practice snoozed: whether or not the health checker is snoozed Diffs (updated) ----- src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_health_checker.py a4e215d4422e3ada7b7913eaab105fdf030695c5 src/test/python/apache/aurora/executor/test_thermos_executor.py c8fab307d17949a8157659c4b3944ec7520feb9d Diff: https://reviews.apache.org/r/30647/diff/ Testing ------- ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman --===============3207393383832757344==--