Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3F9E17A45 for ; Fri, 20 Feb 2015 17:56:44 +0000 (UTC) Received: (qmail 39904 invoked by uid 500); 20 Feb 2015 17:56:44 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 39855 invoked by uid 500); 20 Feb 2015 17:56:44 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 39843 invoked by uid 99); 20 Feb 2015 17:56:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 17:56:44 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 Feb 2015 17:56:42 +0000 Received: (qmail 36921 invoked by uid 99); 20 Feb 2015 17:56:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Feb 2015 17:56:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0B6101C0513; Fri, 20 Feb 2015 17:56:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7508640560507731262==" MIME-Version: 1.0 Subject: Re: Review Request 31171: Saving backups asynchronously. From: "Joshua Cohen" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" , "Joshua Cohen" Date: Fri, 20 Feb 2015 17:56:21 -0000 Message-ID: <20150220175621.21353.96565@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31171/ X-Sender: "Joshua Cohen" References: <20150219235841.21354.1543@reviews.apache.org> In-Reply-To: <20150219235841.21354.1543@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7508640560507731262== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73291 ----------------------------------------------------------- Is it worth adding a test to StorageBackupTest asserting that we write the backup asynchronously (i.e. some expectation on the mock executor service)? src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java I think this assignment obviates the need to assign to a new FakeClock above? - Joshua Cohen On Feb. 19, 2015, 11:58 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31171/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 11:58 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-1108 > https://issues.apache.org/jira/browse/AURORA-1108 > > > Repository: aurora > > > Description > ------- > > Wrapped backup file handling into Runnable to handle asynchronously. > > Refactoring somehow triggered a findbugs warning that I had to address as well: > "Exceptional return value of java.io.File.delete() ignored in org.apache.aurora.scheduler.storage.backup.StorageBackup$StorageBackupImpl$1.run()" > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 71feb5779df5738a92e587f9f66f915961f52d1d > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java a20378a01575c399c23c86aa784424fc6909c34e > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java ea33037d86f30f0787136f34dad34b88eceb0a4d > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 7602d112d29454608a97ec81de14b6bf0c45df68 > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 15fc4404fa2ace4391e4ddc7153c848bc91d43df > > Diff: https://reviews.apache.org/r/31171/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============7508640560507731262==--