Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6070517808 for ; Thu, 19 Feb 2015 01:45:42 +0000 (UTC) Received: (qmail 30410 invoked by uid 500); 19 Feb 2015 01:45:42 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 30359 invoked by uid 500); 19 Feb 2015 01:45:42 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 30346 invoked by uid 99); 19 Feb 2015 01:45:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Feb 2015 01:45:42 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 19 Feb 2015 01:45:19 +0000 Received: (qmail 30170 invoked by uid 99); 19 Feb 2015 01:45:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Feb 2015 01:45:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4945B1D21F8; Thu, 19 Feb 2015 01:45:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5007084127516468313==" MIME-Version: 1.0 Subject: Re: Review Request 31171: Saving backups asynchronously. From: "Bill Farner" To: "Bill Farner" , "Kevin Sweeney" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 19 Feb 2015 01:45:15 -0000 Message-ID: <20150219014515.21353.902@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31171/ X-Sender: "Bill Farner" References: <20150219002712.21354.95973@reviews.apache.org> In-Reply-To: <20150219002712.21354.95973@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5007084127516468313== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31171/#review73064 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java I think the defer should be here. As the diff stands, `backupNow()` returns before the backup completes, changing the behavior of an administrator RPC. Given that there's no other way for an administrator to know that a backup completed, it's best to preserve that behavior. - Bill Farner On Feb. 19, 2015, 12:27 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31171/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 12:27 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-1108 > https://issues.apache.org/jira/browse/AURORA-1108 > > > Repository: aurora > > > Description > ------- > > Wrapped backup file handling into Runnable to handle asynchronously. > > Refactoring somehow triggered a findbugs warning that I had to address as well: > "Exceptional return value of java.io.File.delete() ignored in org.apache.aurora.scheduler.storage.backup.StorageBackup$StorageBackupImpl$1.run()" > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 71feb5779df5738a92e587f9f66f915961f52d1d > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java a20378a01575c399c23c86aa784424fc6909c34e > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 7602d112d29454608a97ec81de14b6bf0c45df68 > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java 15fc4404fa2ace4391e4ddc7153c848bc91d43df > > Diff: https://reviews.apache.org/r/31171/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============5007084127516468313==--