Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D206410E5C for ; Wed, 18 Feb 2015 01:13:45 +0000 (UTC) Received: (qmail 69832 invoked by uid 500); 18 Feb 2015 01:13:45 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 69784 invoked by uid 500); 18 Feb 2015 01:13:45 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 69773 invoked by uid 99); 18 Feb 2015 01:13:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 01:13:45 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Feb 2015 01:13:23 +0000 Received: (qmail 67642 invoked by uid 99); 18 Feb 2015 01:13:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 01:13:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9586D1D20EE; Wed, 18 Feb 2015 01:13:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7366358132720365146==" MIME-Version: 1.0 Subject: Re: Review Request 30647: Instrument the HealthChecker to export stats. From: "Aurora ReviewBot" To: "Bill Farner" , "Joshua Cohen" Cc: "Aurora ReviewBot" , "Aurora" , "Brian Wickman" Date: Wed, 18 Feb 2015 01:13:18 -0000 Message-ID: <20150218011318.21354.70954@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30647/ X-Sender: "Aurora ReviewBot" References: <20150218010058.21354.64558@reviews.apache.org> In-Reply-To: <20150218010058.21354.64558@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7366358132720365146== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review72860 ----------------------------------------------------------- Ship it! Master (4b43305) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 18, 2015, 1 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30647/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 1 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1062 > https://issues.apache.org/jira/browse/AURORA-1062 > > > Repository: aurora > > > Description > ------- > > Instrument the HealthChecker to export stats. > > HealthChecker plugin now should export three stats: > consecutive_failures: number of consecutive failures experienced (resets on success) > latency: how long health checks are taking in practice > snoozed: whether or not the health checker is snoozed > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 > src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 > src/test/python/apache/aurora/executor/common/test_health_checker.py a4e215d4422e3ada7b7913eaab105fdf030695c5 > src/test/python/apache/aurora/executor/test_thermos_executor.py c8fab307d17949a8157659c4b3944ec7520feb9d > > Diff: https://reviews.apache.org/r/30647/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common:: > > > Thanks, > > Brian Wickman > > --===============7366358132720365146==--