Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73F1810E13 for ; Wed, 18 Feb 2015 01:04:29 +0000 (UTC) Received: (qmail 47570 invoked by uid 500); 18 Feb 2015 01:04:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 47539 invoked by uid 500); 18 Feb 2015 01:04:23 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 47528 invoked by uid 99); 18 Feb 2015 01:04:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 01:04:22 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Feb 2015 01:04:00 +0000 Received: (qmail 47362 invoked by uid 99); 18 Feb 2015 01:03:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 01:03:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4ACD61D20EE; Wed, 18 Feb 2015 01:03:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8107737448630162830==" MIME-Version: 1.0 Subject: Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey. From: "Maxim Khutornenko" To: "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Bill Farner" , "Aurora" Date: Wed, 18 Feb 2015 01:03:55 -0000 Message-ID: <20150218010355.21354.58011@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31136/ X-Sender: "Maxim Khutornenko" References: <20150218005359.21354.39750@reviews.apache.org> In-Reply-To: <20150218005359.21354.39750@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8107737448630162830== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136/#review72853 ----------------------------------------------------------- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java Fits on one line? src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java s/UUID/update src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java s/updat/key src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java s/update/key - Maxim Khutornenko On Feb. 18, 2015, 12:53 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31136/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:53 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-1093 > https://issues.apache.org/jira/browse/AURORA-1093 > > > Repository: aurora > > > Description > ------- > > This is stage 1 of 2 or 3 to use `IJobUpdateKey` throughout the system to uniquely identify job updates. This change is localized to the database. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 2a77f28b847d4897315e63c62455e49b370ea5fa > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 39f72ccd8a61d7691d587f1597dc705c44d01ee2 > src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java d5dd5a535a017e84c628a740bcc17cc5ad50e5cc > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 028eb7c0c70049c92f1060625b4a5c498a83d845 > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.java bbd2f465d68109a8d974830a9a4520f28f92a786 > src/main/java/org/apache/aurora/scheduler/storage/db/PruneVictim.java PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.xml 1bc2a620661d766918e655307f76154488c66c5d > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 7fd3a86f636523328ef671b60486fb3f1c3178ec > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml 9f23c4b6cdc015465d68c219dfbecf3522f5c551 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 987596f733b7155fbce772e6c74a8095d5da1827 > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java be5e7727f782200d633fee1cf17491272431f794 > > Diff: https://reviews.apache.org/r/31136/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============8107737448630162830==--