Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A60681054F for ; Tue, 17 Feb 2015 21:39:52 +0000 (UTC) Received: (qmail 22257 invoked by uid 500); 17 Feb 2015 21:39:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 22211 invoked by uid 500); 17 Feb 2015 21:39:52 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 22200 invoked by uid 99); 17 Feb 2015 21:39:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 21:39:52 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Feb 2015 21:39:50 +0000 Received: (qmail 21542 invoked by uid 99); 17 Feb 2015 21:39:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 21:39:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8BDBE1D20E6; Tue, 17 Feb 2015 21:39:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5833994855177231168==" MIME-Version: 1.0 Subject: Re: Review Request 31135: Pin protobuf dependency to 2.6.1 From: "Joe Smith" To: "Joe Smith" , "Kevin Sweeney" Cc: "Aurora" , "Zameer Manji" Date: Tue, 17 Feb 2015 21:39:29 -0000 Message-ID: <20150217213929.21353.98783@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joe Smith" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31135/ X-Sender: "Joe Smith" References: <20150217211532.21353.74569@reviews.apache.org> In-Reply-To: <20150217211532.21353.74569@reviews.apache.org> Reply-To: "Joe Smith" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5833994855177231168== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/#review72799 ----------------------------------------------------------- Ship it! Ship It! - Joe Smith On Feb. 17, 2015, 1:15 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31135/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 1:15 p.m.) > > > Review request for Aurora, Joe Smith and Kevin Sweeney. > > > Bugs: AURORA-1128 > https://issues.apache.org/jira/browse/AURORA-1128 > > > Repository: aurora > > > Description > ------- > > Pin protobuf dependency to 2.6.1 > > > Diffs > ----- > > 3rdparty/python/requirements.txt PRE-CREATION > src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d > src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9 > src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968 > > Diff: https://reviews.apache.org/r/31135/diff/ > > > Testing > ------- > > $ ./pants binary src/main/python/apache/aurora/executor/bin:thermos_executor && ./pants binary src/main/python/apache/aurora/executor/bin:gc_executor > $ unzip gc_executor.pex -d gc_executor > $ unzip thermos_executor.pex -d thermos_executor > $ ls gc_executor/.deps/ | grep protobuf > protobuf-2.6.1-py2.7.egg > $ ls thermos_executor/.deps/ | grep protobuf > protobuf-2.6.1-py2.7.egg > $ ./pants test.pytest --no-fast src/test/python:: > > > Thanks, > > Zameer Manji > > --===============5833994855177231168==--