Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9EC91177CD for ; Tue, 17 Feb 2015 06:23:03 +0000 (UTC) Received: (qmail 99671 invoked by uid 500); 17 Feb 2015 06:23:03 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 99623 invoked by uid 500); 17 Feb 2015 06:23:03 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 99612 invoked by uid 99); 17 Feb 2015 06:23:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 06:23:03 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Feb 2015 06:23:01 +0000 Received: (qmail 99579 invoked by uid 99); 17 Feb 2015 06:22:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 06:22:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 819731D1598; Tue, 17 Feb 2015 06:22:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6703900301477498237==" MIME-Version: 1.0 Subject: Review Request 31104: task-executor: TASK_RUNNING after first health check From: "Moses Nakamura" To: "Brian Wickman" Cc: "Moses Nakamura" , "Aurora" Date: Tue, 17 Feb 2015 06:22:40 -0000 Message-ID: <20150217062240.21354.61410@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Moses Nakamura" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/31104/ X-Sender: "Moses Nakamura" Reply-To: "Moses Nakamura" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6703900301477498237== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104/ ----------------------------------------------------------- Review request for Aurora and Brian Wickman. Repository: aurora Description ------- This is the first step in changing TASK_RUNNING to mean that the application is alive and responding to health checks (if the task is configured to support health checks). This review is just to get feedback, I can't do this review in parts because the scheduler must be changed in lockstep with the executor, or everything will break. I don't know if this is the right approach, could you give me some high level advice? I'm also not sure who to add to this review. Diffs ----- src/main/python/apache/aurora/executor/aurora_executor.py 9c0282392dbb9cca308baf47adc1750c1f5cacc6 src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530 src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a src/main/python/apache/aurora/executor/common/status_checker.py 624921d68199df098ea51ee8a10815403bf58984 src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e src/test/python/apache/aurora/executor/common/test_health_checker.py def249c2509a28f7145380f250f79202b653dc83 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a Diff: https://reviews.apache.org/r/31104/diff/ Testing ------- This hangs after I call is_health_checks_enabled, and I don't know why. My suspicion is that I'm throwing an exception and cratering the task executor, but I don't know how to tell. How do I get it to print? I'm running it with: ./pants test src/test/python/apache/aurora/executor:: Thanks, Moses Nakamura --===============6703900301477498237==--