Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ABB7E10D80 for ; Tue, 10 Feb 2015 01:51:04 +0000 (UTC) Received: (qmail 99752 invoked by uid 500); 10 Feb 2015 01:51:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 99640 invoked by uid 500); 10 Feb 2015 01:51:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 99468 invoked by uid 99); 10 Feb 2015 01:51:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 01:51:04 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 10 Feb 2015 01:43:21 +0000 Received: (qmail 89389 invoked by uid 99); 10 Feb 2015 01:43:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 01:43:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BA3FD1CE00D; Tue, 10 Feb 2015 01:43:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4267128909580297060==" MIME-Version: 1.0 Subject: Re: Review Request 30749: Port GC executor to PathDetector interface From: "Zameer Manji" To: "Zameer Manji" , "Joshua Cohen" Cc: "Aurora" , "Brian Wickman" Date: Tue, 10 Feb 2015 01:43:17 -0000 Message-ID: <20150210014317.29075.75715@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30749/ X-Sender: "Zameer Manji" References: <20150209231620.29075.87755@reviews.apache.org> In-Reply-To: <20150209231620.29075.87755@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4267128909580297060== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71741 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On Feb. 9, 2015, 3:16 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30749/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 3:16 p.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1025 > https://issues.apache.org/jira/browse/AURORA-1025 > > > Repository: aurora > > > Description > ------- > > This makes the GC executor detect checkpoint roots via the PathDetector interface. This paves the way to detecting checkpoint roots both from /var/run/thermos and from /var/lib/mesos/** > > > Diffs > ----- > > src/main/python/apache/aurora/executor/bin/BUILD 1fa1e9e839bf28093b4e9ded403a761cf4bf5f44 > src/main/python/apache/aurora/executor/bin/gc_executor_main.py b903bcb3630a8a8d50a2008bfae532b2eb947356 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0752d50015b2ff936f079c4a9f2777172dc00a93 > src/main/python/apache/aurora/executor/gc_executor.py 43b415bc6c5177be24ec036cc32ae7cbd87fc70f > src/main/python/apache/thermos/bin/thermos.py 161bbdbc4de95c82e2b596e77b0eac7b920eae66 > src/main/python/apache/thermos/monitoring/garbage.py 69bf8e4c2e2e5f85f6b822fbe45f828d61814d7f > src/test/python/apache/aurora/executor/bin/BUILD PRE-CREATION > src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py PRE-CREATION > src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py PRE-CREATION > src/test/python/apache/aurora/executor/test_gc_executor.py b1bbc89a822302d8ea12324eb767631326639ebb > > Diff: https://reviews.apache.org/r/30749/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/main/python:: > > > Thanks, > > Brian Wickman > > --===============4267128909580297060==--