Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56D3B10D27 for ; Tue, 10 Feb 2015 01:43:09 +0000 (UTC) Received: (qmail 89288 invoked by uid 500); 10 Feb 2015 01:43:09 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 89242 invoked by uid 500); 10 Feb 2015 01:43:09 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 59841 invoked by uid 99); 10 Feb 2015 01:01:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 01:01:29 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 10 Feb 2015 01:01:28 +0000 Received: (qmail 59686 invoked by uid 99); 10 Feb 2015 01:01:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 01:01:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E54D31CE00D; Tue, 10 Feb 2015 01:01:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3671405991744062062==" MIME-Version: 1.0 Subject: Re: Review Request 30325: Implementing pulseJobUpdate RPC. From: "Aurora ReviewBot" To: "Bill Farner" , "Joshua Cohen" , "David McLaughlin" Cc: "Aurora" , "Aurora ReviewBot" , "Maxim Khutornenko" Date: Tue, 10 Feb 2015 01:01:07 -0000 Message-ID: <20150210010107.29075.3047@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/30325/ X-Sender: "Aurora ReviewBot" References: <20150210005336.29075.31674@reviews.apache.org> In-Reply-To: <20150210005336.29075.31674@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============3671405991744062062== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71730 ----------------------------------------------------------- This patch does not apply cleanly on master (68aa285), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30325/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 12:53 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. > > > Bugs: AURORA-1009 > https://issues.apache.org/jira/browse/AURORA-1009 > > > Repository: aurora > > > Description > ------- > > Implemented the `pulseJobUpdate` RPC. > > The RB is diffed against https://reviews.apache.org/r/30225/ > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift 4f603f9e7ed004e53937a45ea8edf7241e15f5cf > src/main/java/org/apache/aurora/auth/CapabilityValidator.java 45ef643ebe57c1517cdae373574331ea302a8b74 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fd4d6908fe7680808cfdee9e78c37506af280068 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a9966a823e9616d0bf9bd19fd62e632d931ddf0a > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 4bf63921f8aa4be943b2b9a7b0be9fb33f7762db > > Diff: https://reviews.apache.org/r/30325/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============3671405991744062062==--