aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.
Date Fri, 27 Feb 2015 22:48:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 10:48 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
-------

Add a spec_set on the options_mock for cli/commands/test_simplerun.


Bugs: AURORA-1027
    https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
-------

This splits src/main/python/apache/thermos/bin/thermos.py into src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we can easily
add a customized aurora entry point for thermos that is capable of finding checkpoint roots
in executor sandboxes.  Added said entry point in src/main/apache/aurora/tools/thermos.py
-- open for other suggestions where this should live (possibly under aurora/executor/bin?)
 This is a drop-in replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in gc, status
and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not go with full
coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-----

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20

  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
-------

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message