aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.
Date Fri, 27 Feb 2015 20:22:43 GMT


> On Feb. 27, 2015, 8:20 p.m., Zameer Manji wrote:
> > Just to be clear, this is because it doesn't make sense to have rollback with restarts
right?

Yeah, there is nothing to rollback to in case of restarts that by definition use the same
task config.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74573
-----------------------------------------------------------


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
>     https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 4485675190b1b69cf78e042e9888d26fb924ea92

>   src/test/python/apache/aurora/client/cli/test_restart.py aa389b48fe03a186bfa51dab4560b65a7334be51

> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message