aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
Date Thu, 26 Feb 2015 22:46:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 10:46 p.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
-------

Fix one missing self._state check.


Bugs: AURORA-1155
    https://issues.apache.org/jira/browse/AURORA-1155


Repository: aurora


Description
-------

Add basic test coverage to the TaskGarbageCollector.


Diffs (updated)
-----

  src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe

  src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634

  src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31491/diff/


Testing
-------

./pants test src/test/python/apache/thermos/monitoring:test_garbage


Thanks,

Brian Wickman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message