aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
Date Thu, 26 Feb 2015 19:55:59 GMT


> On Feb. 26, 2015, 7:46 p.m., Joshua Cohen wrote:
> > src/main/python/apache/thermos/monitoring/garbage.py, line 83
> > <https://reviews.apache.org/r/31491/diff/1/?file=878599#file878599line83>
> >
> >     What's the purpose of these comments?

ugh, keep forgetting to delete these comments


> On Feb. 26, 2015, 7:46 p.m., Joshua Cohen wrote:
> > src/main/python/apache/thermos/monitoring/garbage.py, lines 44-47
> > <https://reviews.apache.org/r/31491/diff/1/?file=878599#file878599line44>
> >
> >     safe_mtime?

derp yeah


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491/#review74343
-----------------------------------------------------------


On Feb. 26, 2015, 7:20 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31491/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 7:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1155
>     https://issues.apache.org/jira/browse/AURORA-1155
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add basic test coverage to the TaskGarbageCollector.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe

>   src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634

>   src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31491/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/monitoring:test_garbage
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message