aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Niemitz" <st...@tellapart.com>
Subject Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners
Date Wed, 25 Feb 2015 21:22:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/
-----------------------------------------------------------

(Updated Feb. 25, 2015, 9:22 p.m.)


Review request for Aurora, Brian Wickman and Zameer Manji.


Repository: aurora


Description (updated)
-------

Stop the announcer and status checkers before starting to kill the runners.

This allows the task to be removed from the ZK ensemble before it begins getting killed. 
The delay can be significant if the task takes some time to shutdown, and during the time
it stops responding to requests.


Diffs
-----

  src/main/python/apache/aurora/executor/aurora_executor.py 9c0282392dbb9cca308baf47adc1750c1f5cacc6


Diff: https://reviews.apache.org/r/31423/diff/


Testing
-------

We're now running this in our production environments.  Watching ZK, I can confirm that the
nodes are removed before process shutdown begins.  Watching the executor log also confirms
this.

I couldn't observe any other side effects either.


Thanks,

Steve Niemitz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message