aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Pfeiffer" <apacherevi...@x8s.de>
Subject Review Request 31406: Adding possiblity to define the port where the health checker should run on
Date Wed, 25 Feb 2015 10:57:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31406/
-----------------------------------------------------------

Review request for Aurora.


Bugs: AURORA-321
    https://issues.apache.org/jira/browse/AURORA-321


Repository: aurora


Description
-------

Adding the possiblity to define the port where the health checker should run on

Note: The added mesos_task to the task runner seems to make the old task object superfluous.
I wasn't sure if I could remove the task object that easily without breaking stuff, though.

If we will go the way, that we're separating graceful teardown from healthcheck, we probably
need the mesos_task object as well


Diffs
-----

  src/main/python/apache/aurora/config/schema/base.py a87524a8b3ad5aa0e337e0a0028cecb85865b4e6

  src/main/python/apache/aurora/executor/common/health_checker.py 60676ba0fbd8a218fe4309f07de28e2c66d54530

  src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1


Diff: https://reviews.apache.org/r/31406/diff/


Testing
-------

test_end_to_end.sh


Thanks,

Florian Pfeiffer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message